Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump cargo-make to 0.35.10, pin taplo-cli at 0.6.0 #525

Merged
merged 4 commits into from Apr 20, 2022
Merged

ci: bump cargo-make to 0.35.10, pin taplo-cli at 0.6.0 #525

merged 4 commits into from Apr 20, 2022

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Apr 20, 2022 •
edited

john-michaelburke
john-michaelburke approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 blows my mind still not seeing this in any repo issues.

@silverjam silverjam changed the title ci: bump cargo-make to 0.35.10 ci: bump cargo-make to 0.35.10, pin taplo-cli at 0.6.0 Apr 20, 2022
@john-michaelburke
Copy link
Collaborator

Maybe we just disable this check in the meantime?
tamasfe/taplo#241

Taplo maintainer posted an issue on jsonschema:
Stranger6667/jsonschema-rs#356

@silverjam
Copy link
Contributor Author

Maybe we just disable this check in the meantime? tamasfe/taplo#241

Taplo maintainer posted an issue on jsonschema: Stranger6667/jsonschema-rs#356

I think I finally got the pinning figured out, but we should log an issue to revisit this once jsonschema is fixed

@silverjam silverjam merged commit ccfc0af into main Apr 20, 2022
@silverjam silverjam deleted the silverjam/update-cargo-make branch April 20, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-michaelburke john-michaelburke john-michaelburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silverjam @john-michaelburke