Create packages for generating evm ecosystem configs #164
Conversation
Deploying with
|
| Latest commit: |
b7093be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d283bed7.swim-ui.pages.dev |
| Branch Preview URL: | https://evm-spike.swim-ui.pages.dev |
…nd address pr comments
…, bsc, polygon, and avax
| @@ -0,0 +1,86 @@ | |||
| { | |||
There was a problem hiding this comment.
If this PR gets merged first we can replace all of these: #168
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:@typescript-eslint/recommended-requiring-type-checking", |
There was a problem hiding this comment.
Are some of these new? Not for this PR I think, but could you add submit a PR against the sdk/eslint branch with them in?
There was a problem hiding this comment.
Don't think these are new. Most of the other packages have them as well. I'll double check that branch though and add in any new ones.
There was a problem hiding this comment.
Ah, I see they're already in some non-UI packages. All good.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
There was a problem hiding this comment.
Maybe it's time for a tsconfig.package.json and a tsconfig.app.json for all the normal compiler options we repeatedly set in these.
There was a problem hiding this comment.
By this do you just mean there's one in the packages directory and one in apps that have all the common options we're setting in these? I suppose either way it'll probably make more sense as a separate PR.
There was a problem hiding this comment.
Hadn't thought much about location, but yep can be part of this: https://www.notion.so/exsphere/Improve-tsconfig-json-file-2afa2c859a7e4416a175b983beb7e23d
wormat
changed the title
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:@typescript-eslint/recommended-requiring-type-checking", |
There was a problem hiding this comment.
Ah, I see they're already in some non-UI packages. All good.
|
Superseded by other work/decisions. |
Notion ticket: N/A
Checklist