Enable trim and wrap feature to axis label #1905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
X axis label is moved down when wrap x axis label is enabled. The distance between the top of the x axis label and the bottom of the chart should be the same for when wrap is enabled and disabled. Same thing happens to the y axis label. The distance between the right of the y axis label and the left of the chart should be the same for when wrap is enabled and disabled. |
Lyq322
reviewed
Dec 24, 2023
| @@ -12,6 +12,7 @@ import { | |||
| import { XAxisTicksComponent } from './x-axis-ticks.component'; | |||
| import { Orientation } from '../types/orientation.enum'; | |||
| import { ViewDimensions } from '../types/view-dimension.interface'; | |||
| import { select } from 'd3-selection'; | |||
There was a problem hiding this comment.
Group d3 import with other external imports (eg @angular/core)
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis.component.ts
Outdated
Show resolved
Hide resolved
| // labelLength = number of characters | ||
| let labelLength = this.labelText.length; | ||
| this.labelTextTemp = this.labelText; | ||
| this.maxLabelLength = Number(this.maxLabelLength); |
There was a problem hiding this comment.
Isn't this.maxLabelLength already a number?
projects/swimlane/ngx-charts/src/lib/common/axes/y-axis.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/y-axis.component.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+25
to
+27
| @Input() maxLabelLength: number; | ||
| @Input() trimLabel: boolean; | ||
| @Input() wrapLabel: boolean; |
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
…ent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
The appearance of the long axis label is visually unappealing.
Issue #1904What is the new behavior?
Applied the following feature to Vertical Bar chart and horizontal Bar chart
Does this PR introduce a breaking change? (check one with "x")