New Line-Pie Combo Chart #1917
Open
New Line-Pie Combo Chart #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial pie chart does not change when real-time data is enabled. Only the line chart data changes |
|
Unclear which data is for pie chart and which is for line chart. |
|
Fit container does not work. Dimensions were not changed after enabling fit container. |
|
Currently, it seems that the two charts are separated by a fixed distance. This causes the pie and line charts to be too far apart when the dimensions are small and too close together when the dimensions are large. |
Lyq322
reviewed
Dec 24, 2023
projects/swimlane/ngx-charts/src/lib/line-chart/line-chart.component.ts
Outdated
Show resolved
Hide resolved
…ponent.ts Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Co-authored-by: Yuqing Liu <47932418+Lyq322@users.noreply.github.com>
Thanks for suggestion, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Issue #1916
What is the new behavior?
When the mouse is not hovered over the line chart x-axis node, the pie chart displays the sum of the values for each legend group. When the mouse is over one of the x-axis nodes of the line chart, the pie chart shows the distribution of y-values for each country at that x-value.
The combo chart supports all reasonable features of line chart and pie chart respectively.
Does this PR introduce a breaking change? (check one with "x")