Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): render sourcemap for css files on dev #2063

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Oct 10, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: 105fda1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +54 to +58
return mergeConfig(config, {
css: {
devSourcemap: true,
},
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imagoiq imagoiq linked an issue Oct 10, 2023 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 10, 2023

Preview environment ready: https://preview-2063--swisspost-design-system-next.netlify.app

@imagoiq imagoiq self-assigned this Oct 10, 2023
packages/documentation/package.json Outdated Show resolved Hide resolved
imagoiq and others added 2 commits October 12, 2023 09:17
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imagoiq imagoiq merged commit ed101b1 into main Oct 12, 2023
9 checks passed
@imagoiq imagoiq deleted the feat/2053-docs-css-sourcemap branch October 12, 2023 08:22
imagoiq added a commit that referenced this pull request Oct 17, 2023
#2063 introduces another
`vite` package version (v4.4.11) which is not the same as the one behind
Storybook (v4.4.7). It seems that there are incompatibilities as the
`*.entry.js` files of the components packages are not built with this
change.

This PR removes this `vite` package and the code relies on the
sub-dependency `vite` package of storybook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up sourcemaps for storybook
3 participants