-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Futures #145
Open
leocavalcante
wants to merge
5
commits into
master
Choose a base branch
from
futures
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introducing Futures #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return new self($func); | ||
} | ||
|
||
public static function join(array $futures, float $timeout = -1): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation is good and readable. But, I would put some minor tweaks (not functional ones, just a different style and one less variable to decrement) into it:
public static function join(array $futures, float $timeout = -1): array
{
$ch = new Channel(count($futures));
Coroutine::join(array_map(static function (Future $future) use ($ch): int {
return $future->run($ch);
}, $futures));
$rets = [];
while ($ret = $ch->pop($timeout)) {
if ($ret instanceof Throwable) {
throw $ret;
}
$rets[] = $ret;
}
return $rets;
}
@leocavalcante This is really nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Futures as part of Swoole's standard library features.
Futures are abstractions on top of Coroutines providing alternative syntax for building concurrent programs with Swoole.
Main differences from Coroutines are:
Futures are lazy
They don't evaluate until you call
await
:Futures can return values
The
Channel
handling is done under the hood:Futures propagates exceptions
Futures synchronization is similar
It uses
Coroutine::join
under the hood: