add action clickToCopy #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #17.
I ended up having each half of try/catch dispatch a 'copysuccess' or 'copyerror' event so elements can listen for these specific actions instead of any copy events on the page.
Also, I tried and failed implementing tests for this and after looking more into JSDOM I think it's because
navigator.clipboarddoesn't exist in their code and I'm not yet sure how to mock global methods like that (learning in public 馃槄). I'm new to open source, and programming in general, so I really appreciate you taking time out of your day for this. Thanks!