Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color: Removal of nyan-mode local copy #16361

Merged

Conversation

tonyfloatersu
Copy link
Contributor

Hi there,

I opened up this PR as I encountered the same issue in #12946, that
nyan-mode won't show up under doom-modeline setting. The solution
here seems to be taking advantage of the nyan-mode on MELPA, which
is essentially the one-line change in colors/packages.el. If we go down
this way, then we can take away the local copy of nyan-mode altogether.

I also checked around and removed some text mentioning nyan-mode,
but I am unsure if we are allowed to do so (for example in COPYRIGHT).
I would refer the decision up to the code owner.

Thanks in advance for reviewing bandwidth.

Hang

@smile13241324
Copy link
Collaborator

smile13241324 commented May 31, 2024

I am not sure that's that easy, I dimly remember that there is an open pr with improvements to the nyan cat animation from sylable which never has been merged.

I think we need to either get this merged or do a fork ourselves.

Anyway I am going to merge it for now for when it stopped working entirely for one theme its more important than the improved graphics but we should still try to get these back in time

@smile13241324 smile13241324 merged commit 9cddd15 into syl20bnr:develop May 31, 2024
3 checks passed
@tonyfloatersu
Copy link
Contributor Author

Oh thanks for the context of nyan cat animation improvement, I was totally unaware of that... but thanks for taking a look and thanks for merging

@tonyfloatersu tonyfloatersu deleted the local-nyan-mode-removal branch May 31, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants