Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings to restart python shell #16389

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

rommeswi
Copy link
Contributor

@rommeswi rommeswi commented May 6, 2024

Thank you for the excellent python layer.

I noticed a minor issue: the bindings do not include a way to restart the shell conveniently.
It would be natural to include these in the SPC m s bindings.
E.g., SPC m s includes commands to remove unused imports or start a shell.

I would also suggest to replace the uninformative 'prefix' as the description for SPC m s by 'python-shell' or 'shell' but did not include this in the PR.

Chose 'n' for the mnemonic "new"
spacemacs/python-shell-restart-switch restarts the python shell and switches to it in insert mode

spacemacs/python-shell-restart restarts the python shell

These seem commands that are common enough used to warrant a default keybinding.
Copy link
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to add the new bindings to the layer readme.

@smile13241324 smile13241324 merged commit a788022 into syl20bnr:develop May 15, 2024
6 of 8 checks passed
ViktorHaag pushed a commit to ViktorHaag/spacemacs that referenced this pull request May 16, 2024
* Adds bindings to restart python shell

Chose 'n' for the mnemonic "new"

* Adds spacemacs functions to restart python shell

spacemacs/python-shell-restart-switch restarts the python shell and switches to it in insert mode

spacemacs/python-shell-restart restarts the python shell

These seem commands that are common enough used to warrant a default keybinding.

* Adds documentation for new bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants