Skip to content

refactor: simplify zero implementation #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

tri-adam
Copy link
Member

Replace func zeroData with a simpler implementation that uses an io.Reader that streams zero bytes.

@tri-adam tri-adam self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #328 (59cf700) into main (e1f38f0) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   72.77%   72.80%   +0.02%     
==========================================
  Files          35       35              
  Lines        2964     2956       -8     
==========================================
- Hits         2157     2152       -5     
+ Misses        648      646       -2     
+ Partials      159      158       -1     
Files Changed Coverage Δ
pkg/sif/create.go 71.13% <66.66%> (+0.17%) ⬆️

@tri-adam tri-adam marked this pull request as ready for review September 19, 2023 19:53
@tri-adam tri-adam merged commit cac8e77 into sylabs:main Sep 20, 2023
@tri-adam tri-adam deleted the refactor-zero branch September 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants