Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove slash on the elasticsearch url #299

Closed
wants to merge 1 commit into from

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Mar 24, 2023

Right now the URL is like http://127.0.0.1:49155/

This causes errors like:

BadRequest400Exception {"error":"no handler found for uri [/_search] and method [POST]"}

because on OpenSearch Client it will append a double slash to all urls.

So I have removed the trailing slash

@tucksaun
Copy link
Contributor

This was added on purpose: see #155 and #154

@shyim shyim closed this Mar 27, 2023
@shyim shyim deleted the patch-1 branch March 27, 2023 10:52
@shyim
Copy link
Contributor Author

shyim commented Mar 27, 2023

I will adjust it in our application. But for me it's still a issue in symfony-cli and platform.sh is for me not "the standard way" to do it :)

@tucksaun
Copy link
Contributor

Yeah, trailing or non-trailing slashes are always a bit difficult as you never know what you will end up with 😕
In libraries or foundation code where a developer or end-user can input something of their choice, I personally tend to always normalize trailing slashes the way I expect things to be just to be on the safe side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants