Merge $_ENV into $_SERVER earlier in phprouter file

[kick-the-bucket]

Tried running a non-symfony application with the symfony-cli local server and was puzzled why it could not detect that it's running on https. Apparently 'https' => 'on' was only set in $_ENV (that's done with require $envFile;), but not in $_SERVER, where PHP applications usually look for that parameter.

This was because the $_SERVER = array_merge($_SERVER, $_ENV); line was never executed, because the router exited a few lines before it with return false;.

Also fixed a few whitespace and indentation inconsistencies.

[tucksaun]

PHP documents the presence of HTTPS within $_SERVER (see https://www.php.net/manual/en/reserved.variables.server.php), not $_ENV.
And I believe most of the literature online also references $_SERVER.

So I think we are within spec here, your app should probably be fixed instead.

[tucksaun]

Also I don't quite understand how your application could even be reached if the router exited before the call to array_merge 🤔

[kick-the-bucket]

After that return false; it just continues to my index.php, not really sure how that works, maybe the router file is set as an auto_prepend_file 🤔

[kick-the-bucket]

PHP documents the presence of HTTPS within $_SERVER (see https://www.php.net/manual/en/reserved.variables.server.php), not $_ENV.
And I believe most of the literature online also references $_SERVER.

The problem is that the code in the $envFile only sets $_ENV['https'] = 'on', but nothing on the $_SERVER and that is why the merge is needed in the first place

[tucksaun]

Oh ok sorry I got that the wrong way.

So I believe the change might makes sense, but at the same time this is the location this merge has been present for quite a long time in Symfony so I'm not entirely sure of the consequences this could have...

Another approach would be to change how we generate the env for the PHP CLI server to make sure the right keys are populated for _SERVER, something along those lines: https://github.com/symfony-cli/symfony-cli/compare/main...tucksaun:symfonycli:fix-generate-server-superglobal-cli-server?expand=1

wdyt @fabpot ?

[kick-the-bucket]

@tucksaun I actually like your version, no point in setting the variables on $_ENV which are supposed to be in $_SERVER anyways 👍