Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doctrine.dbal.connections.default.server_version in addition to doctrine.dbal.server_version #432

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Feb 9, 2024

No description provided.

@nicolas-grekas
Copy link
Contributor

DoctrineBundle already handles the merging of the yaml and the DSN so we should like remove all the yaml-related logic here:
https://github.com/doctrine/DoctrineBundle/blob/2.11.x/ConnectionFactory.php#L251

@fabpot
Copy link
Contributor Author

fabpot commented Feb 9, 2024

Fixed #425

@fabpot
Copy link
Contributor Author

fabpot commented Feb 9, 2024

DoctrineBundle already handles the merging of the yaml and the DSN so we should like remove all the yaml-related logic here: https://github.com/doctrine/DoctrineBundle/blob/2.11.x/ConnectionFactory.php#L251

We are always specifying a version in the URL env var. So, the version set in doctrine.yaml can never be used.

@fabpot fabpot merged commit 154cb00 into main Feb 9, 2024
2 checks passed
@fabpot fabpot deleted the doctrine-config-fix branch February 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants