Add first integration tests #435
Open
+353
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucksaun
reviewed
Feb 16, 2024
| } | ||
|
|
||
| for _, command := range startCommands { | ||
| cmd := exec.Command(strings.Split(command, " ")[0], strings.Split(command, " ")[1:]...) |
There was a problem hiding this comment.
to get more control I would rather directly use the code here (starting the server in a goroutine and issuing http request, worst case: starting the application instead of directly the HTTP server).
There was a problem hiding this comment.
Would you do this in all functional tests or only this one? About issuing HTTP request, it is only relevant for starting and stopping the server (and not listing running ones), right?
|
thank you for starting the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a quick chat with @tucksaun, here's a try on adding a few integration tests. I only added a few ones to validate the way of doing this before going further. 🙂