Default ansi option to null

symfony · Nov 21, 2021 · 3e7ab8f · 3e7ab8f
1 parent 9523e73
commit 3e7ab8f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 11 deletions.
diff --git a/Application.php b/Application.php
@@ -1040,7 +1040,7 @@ protected function getDefaultInputDefinition()
             new InputOption('--quiet', '-q', InputOption::VALUE_NONE, 'Do not output any message'),
             new InputOption('--verbose', '-v|vv|vvv', InputOption::VALUE_NONE, 'Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug'),
             new InputOption('--version', '-V', InputOption::VALUE_NONE, 'Display this application version'),
-            new InputOption('--ansi', '', InputOption::VALUE_NEGATABLE, 'Force (or disable --no-ansi) ANSI output', false),
+            new InputOption('--ansi', '', InputOption::VALUE_NEGATABLE, 'Force (or disable --no-ansi) ANSI output', null),
             new InputOption('--no-interaction', '-n', InputOption::VALUE_NONE, 'Do not ask any interactive question'),
         ]);
     }

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ CHANGELOG
  * Add support for bright colors
  * Add `#[AsCommand]` attribute for declaring commands on PHP 8
  * Add `Helper::width()` and `Helper::length()`
+ * The `--ansi` and `--no-ansi` options now default to `null`.
 
 5.2.0
 -----

diff --git a/Tests/Fixtures/application_1.md b/Tests/Fixtures/application_1.md
@@ -103,7 +103,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -230,7 +230,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 

diff --git a/Tests/Fixtures/application_2.md b/Tests/Fixtures/application_2.md
@@ -116,7 +116,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -243,7 +243,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -318,7 +318,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -409,7 +409,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -481,7 +481,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 

diff --git a/Tests/Fixtures/application_mbstring.md b/Tests/Fixtures/application_mbstring.md
@@ -107,7 +107,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -234,7 +234,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`
 
@@ -325,7 +325,7 @@ Force (or disable --no-ansi) ANSI output
 * Is value required: no
 * Is multiple: no
 * Is negatable: yes
-* Default: `false`
+* Default: `NULL`
 
 #### `--no-interaction|-n`