[Console] Fix using #[AsCommand] without DI

symfony · Jun 12, 2021 · 6497304 · 6497304
1 parent ecc138b
commit 6497304
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/Command/Command.php b/Command/Command.php
@@ -101,7 +101,18 @@ public function __construct(string $name = null)
     {
         $this->definition = new InputDefinition();
 
-        if (null !== $name || null !== $name = static::getDefaultName()) {
+        if (null === $name && null !== $name = static::getDefaultName()) {
+            $aliases = explode('|', $name);
+
+            if ('' === $name = array_shift($aliases)) {
+                $this->setHidden(true);
+                $name = array_shift($aliases);
+            }
+
+            $this->setAliases($aliases);
+        }
+
+        if (null !== $name) {
             $this->setName($name);
         }
 

diff --git a/Tests/Command/CommandTest.php b/Tests/Command/CommandTest.php
@@ -414,6 +414,13 @@ public function testCommandAttribute()
     {
         $this->assertSame('|foo|f', Php8Command::getDefaultName());
         $this->assertSame('desc', Php8Command::getDefaultDescription());
+
+        $command = new Php8Command();
+
+        $this->assertSame('foo', $command->getName());
+        $this->assertSame('desc', $command->getDescription());
+        $this->assertTrue($command->isHidden());
+        $this->assertSame(['f'], $command->getAliases());
     }
 }