stop marking parameters implicitly as nullable

symfony · Mar 27, 2024 · 3141777 · 3141777
1 parent c8d73fd
commit 3141777
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/LazyProxy/PhpDumper/DumperInterface.php b/LazyProxy/PhpDumper/DumperInterface.php
@@ -26,7 +26,7 @@ interface DumperInterface
      * @param bool|null   &$asGhostObject Set to true after the call if the proxy is a ghost object
      * @param string|null $id
      */
-    public function isProxyCandidate(Definition $definition/* , bool &$asGhostObject = null, string $id = null */): bool;
+    public function isProxyCandidate(Definition $definition/* , ?bool &$asGhostObject = null, ?string $id = null */): bool;
 
     /**
      * Generates the code to be used to instantiate a proxy in the dumped factory code.
@@ -38,5 +38,5 @@ public function getProxyFactoryCode(Definition $definition, string $id, string $
      *
      * @param string|null $id
      */
-    public function getProxyCode(Definition $definition/* , string $id = null */): string;
+    public function getProxyCode(Definition $definition/* , ?string $id = null */): string;
 }
diff --git a/Tests/Fixtures/includes/autowiring_classes.php b/Tests/Fixtures/includes/autowiring_classes.php
@@ -30,7 +30,7 @@ class Foo
     public static int $counter = 0;
 
     #[Required]
-    public function cloneFoo(\stdClass $bar = null): static
+    public function cloneFoo(?\stdClass $bar = null): static
     {
         ++self::$counter;
 

diff --git a/Tests/Fixtures/includes/autowiring_classes_80.php b/Tests/Fixtures/includes/autowiring_classes_80.php
@@ -107,7 +107,7 @@ public function __construct(string $arg1, #[AutowireDecorated] AsDecoratorInterf
 #[AsDecorator(decorates: \NonExistent::class, onInvalid: ContainerInterface::NULL_ON_INVALID_REFERENCE)]
 class AsDecoratorBaz implements AsDecoratorInterface
 {
-    public function __construct(#[AutowireDecorated] AsDecoratorInterface $inner = null)
+    public function __construct(#[AutowireDecorated] ?AsDecoratorInterface $inner = null)
     {
     }
 }

diff --git a/Tests/Fixtures/includes/classes.php b/Tests/Fixtures/includes/classes.php
@@ -83,7 +83,7 @@ public function callPassed()
 
 class DummyProxyDumper implements DumperInterface
 {
-    public function isProxyCandidate(Definition $definition, bool &$asGhostObject = null, string $id = null): bool
+    public function isProxyCandidate(Definition $definition, ?bool &$asGhostObject = null, ?string $id = null): bool
     {
         $asGhostObject = false;