[make:*] generate test classes properly & fix class name details suffix #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
commented
May 16, 2024
Comment on lines
+156
to
+158
| if (!str_ends_with($className, $suffix)) { | ||
| $className = sprintf('%s%s', $className, $suffix); | ||
| } |
There was a problem hiding this comment.
Hmm... I don't think we should "fix" this here. One could argue that because you're passing an absolute class name into this method, it should not be altered. Under that assumption - this "fix" would actually be a BC break as it's changing the intended functionality from 9e90cbc#diff-4ee5eaad222ef0782fccd29473a5f1860988b7cf91cdcd0a12628b2377972b36
Chewing on this for a better solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a
suffixtoGenerator::createClassNameDetails(), the suffix is not added to an absolute class name. Our docs say that passing a suffix "...guarantee is on the end of the class". This PR fixes that.Generates tests in the proper
App\Tests\namespace instead ofApp\Test\Internals
When generating tests (
--with-tests), I was lazy and usedgenerateFile()to create the test class (in part because of the suffix bug) instead of using the correctgenerateClass()method. This PR fixes that. It's also needed to accomplish #1539 with test classes.