New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow input type checkbox without need to set attribute "name" #550

Open

robertfausk wants to merge 1 commit into symfony:1.x from robertfausk:allow_optional_attribute_name_on_checkbox

Contributor

robertfausk commented Jun 6, 2022

Currently all checkboxes must have a name attribute to be usable with symfony/panther and the ChoiceFormField.

This PR allows instances of WebDriverCheckboxes without a name attribute, e.g.:

<input type="checkbox" value="noNameCheckbox">


          Allow input type checkbox without attribute "name"

8c126a6

robertfausk added a commit to robertfausk/mink-panther-driver that referenced this pull request


          Fix ChangeEventTest::testCheckChangeEvent

8d27eb7

which uses a checkbox without a name attribute by using updated symfony/panther version and an own tag 2.0.2 (https://github.com/robertfausk/panther/releases/tag/v2.0.2)

see also:
symfony/panther#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment