feat: allow selenium server with internal webserver #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What "permission", thank you so much for working on this! \o/ :smile: |
|
Coding Standards fails seem unrelated. @dkarlovi Ok, let's rephrase it then. 😄 |
|
@daFish this looks completed to me, why did you leave is as a draft? |
daFish
force-pushed
the
feat/selenium-devserver
branch
from
db389e2
to
55dad6c
Compare
I made a small info in the README about it. I will remove the draft status and this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #590 by @dkarlovi.
This change allows the usage of an external selenium instance (e.g. via docker compose) to test against the internal webserver.
Todos: