Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOX24 SMS Gateway Notifier #1300

Merged
merged 6 commits into from Apr 14, 2024
Merged

LOX24 SMS Gateway Notifier #1300

merged 6 commits into from Apr 14, 2024

Conversation

alebedev80
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony-docs#19692

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 20, 2024 17:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1300/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1300/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/lox24-notifier:^7.1'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@alebedev80 alebedev80 mentioned this pull request Mar 20, 2024
Merged
OskarStark
OskarStark reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder must be 7.1 not 6.4

auto-merge was automatically disabled March 21, 2024 07:21

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 21, 2024 07:22
auto-merge was automatically disabled March 21, 2024 07:22

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 21, 2024 07:22
@alebedev80 @OskarStark
Update symfony/lox24-notifier/7.1/manifest.json
13c4b90 
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
auto-merge was automatically disabled March 21, 2024 08:25

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 21, 2024 08:26
auto-merge was automatically disabled April 13, 2024 11:50

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) April 13, 2024 11:50
fabpot added a commit to symfony/symfony that referenced this pull request Apr 14, 2024
@fabpot
feature #54356 [Notifier] LOX24 SMS bridge (alebedev80)
cfd9ad0 
This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Notifier] LOX24 SMS bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
|Doc PR| symfony/symfony-docs#19692
|Recipe PR| symfony/recipes#1300

Add LOX24 SMS Gateway bridge to Symfony Notifier.
A Germany based SMS Gateway.

Commits
-------

b1a25ae [Notifier] LOX24 SMS bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Apr 14, 2024
@fabpot
feature #54356 [Notifier] LOX24 SMS bridge (alebedev80)
fbab1fb 
This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Notifier] LOX24 SMS bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
|Doc PR| symfony/symfony-docs#19692
|Recipe PR| symfony/recipes#1300

Add LOX24 SMS Gateway bridge to Symfony Notifier.
A Germany based SMS Gateway.

Commits
-------

b1a25ae139 [Notifier] LOX24 SMS bridge
@symfony-recipes-bot symfony-recipes-bot merged commit 762b0a4 into symfony:main Apr 14, 2024
1 of 2 checks passed
@alebedev80
Copy link
Contributor Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Needs new Package Waiting Code Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alebedev80 @fabpot @OskarStark @symfony-recipes-bot