Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Documented new logout event #13520

Merged
merged 1 commit into from Apr 17, 2020
Merged

[Security] Documented new logout event #13520

merged 1 commit into from Apr 17, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Apr 11, 2020

Fixes #13484

@wouterj wouterj added this to the 5.1 milestone Apr 11, 2020
@wouterj wouterj requested a review from weaverryan April 11, 2020 19:39
noniagriconomie
noniagriconomie approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code/doc additions :)

@wouterj wouterj force-pushed the issue-13484/logout-listener-event branch from 88fe387 to 00089a6 Compare April 12, 2020 13:37
javiereguiluz
javiereguiluz approved these changes Apr 14, 2020
View reviewed changes
security.rst Show resolved Hide resolved
javiereguiluz
javiereguiluz reviewed Apr 16, 2020
View reviewed changes
security.rst Outdated Show resolved Hide resolved
weaverryan
weaverryan reviewed Apr 17, 2020
View reviewed changes
security.rst Outdated Show resolved Hide resolved
weaverryan
weaverryan reviewed Apr 17, 2020
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2 minor comments only :)

@wouterj wouterj force-pushed the issue-13484/logout-listener-event branch from 00089a6 to 1d77a45 Compare April 17, 2020 11:42
@wouterj wouterj merged commit 3ef6848 into symfony:master Apr 17, 2020
@wouterj wouterj deleted the issue-13484/logout-listener-event branch April 17, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@weaverryan weaverryan weaverryan left review comments

@noniagriconomie noniagriconomie noniagriconomie approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Security] Refactor logout listener to dispatch an event instead
5 participants
@wouterj @javiereguiluz @weaverryan @noniagriconomie @carsonbot