[Lock] #37139 Updated Lock MongoDbStore note on readPreference #13775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
Lock
Waiting Code Merge
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 10, 2020
…s (kralos) This PR was squashed before being merged into the 5.1 branch. Discussion ---------- [Lock] Fixed reading locks from replica set secondary nodes | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37139 | License | MIT | Doc PR | symfony/symfony-docs#13775 Force lock existence query to use `readPreference=primary` in case the given mongo connection is using any of the following `readPreference`s: * primaryPreferred * secondary * secondaryPreferred * nearest Any of the above would fail if a secondary node is queried during a lock release. Commits ------- ebf7eaf [Lock] Fixed reading locks from replica set secondary nodes
symfony-splitter
pushed a commit
to symfony/lock
that referenced
this pull request
Jun 10, 2020
…s (kralos) This PR was squashed before being merged into the 5.1 branch. Discussion ---------- [Lock] Fixed reading locks from replica set secondary nodes | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37139 | License | MIT | Doc PR | symfony/symfony-docs#13775 Force lock existence query to use `readPreference=primary` in case the given mongo connection is using any of the following `readPreference`s: * primaryPreferred * secondary * secondaryPreferred * nearest Any of the above would fail if a secondary node is queried during a lock release. Commits ------- ebf7eaf503 [Lock] Fixed reading locks from replica set secondary nodes
carsonbot
changed the title
|
Thank you Joe! Sorry it took us so long to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed documentation around
readPreferenceforMongoDbStoreinLockcomponent. See symfony/symfony#37140