Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong properties class #14077

Merged
merged 1 commit into from Oct 22, 2020
Merged

Fix wrong properties class #14077

merged 1 commit into from Oct 22, 2020

Conversation

makmaoui
Copy link
Contributor

Fix classname for query and cookies properties

@xabbuh xabbuh added this to the 5.1 milestone Aug 15, 2020
@makmaoui @wouterj
Fix wrong properties class
3bc914c 
Fix classname for query and cookies properties
@wouterj wouterj changed the base branch from master to 5.1 October 22, 2020 12:17
@wouterj
Copy link
Member

wouterj commented Oct 22, 2020

Thank you Rachid! These changes are completely valid. I've also updated the request parameter type, following the suggestions from the review.

@wouterj wouterj merged commit 957ad9e into symfony:5.1 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

@OskarStark OskarStark OskarStark left review comments

@maxhelias maxhelias maxhelias left review comments

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@makmaoui @wouterj @weaverryan @OskarStark @xabbuh @maxhelias @carsonbot