[Security] Document InteractiveLoginEvent
#19029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
force-pushed
the
feature/document-login-success-event
branch
from
9c90a4e
to
585e571
Compare
|
Can you add a versionadded? |
|
|
OskarStark
approved these changes
Oct 17, 2023
|
Thank you Antoine. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 2, 2024
…scription (alamirault) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Update `InteractiveAuthenticatorInterface` description | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT `SecurityEvents` phpdoc and `InteractiveAuthenticatorInterface` are contradictory, this PR try to fix it https://github.com/symfony/symfony/blob/d28330faaadb68f59e0d93da101741979db51df0/src/Symfony/Component/Security/Http/SecurityEvents.php#L20-L27 Found it when documenting InteractiveLoginEvent symfony/symfony-docs#19029 Commits ------- 0a66c2b [Security] Update InteractiveAuthenticatorInterface description
symfony-splitter
pushed a commit
to symfony/security-http
that referenced
this pull request
Feb 2, 2024
…scription (alamirault) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Update `InteractiveAuthenticatorInterface` description | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT `SecurityEvents` phpdoc and `InteractiveAuthenticatorInterface` are contradictory, this PR try to fix it https://github.com/symfony/symfony/blob/d28330faaadb68f59e0d93da101741979db51df0/src/Symfony/Component/Security/Http/SecurityEvents.php#L20-L27 Found it when documenting InteractiveLoginEvent symfony/symfony-docs#19029 Commits ------- 0a66c2b15c [Security] Update InteractiveAuthenticatorInterface description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InteractiveLoginEventwas not documentedFound it while reviewing #17595