[Runtime] Update ReactPHP example #19727
Conversation
chadyred
force-pushed
the
doc/update-custom-runtime
branch
7 times, most recently
from
d16b434
to
54ea2ae
Compare
chadyred
force-pushed
the
doc/update-custom-runtime
branch
from
54ea2ae
to
2c0ce01
Compare
|
CI make me trouble about "[Missing class] Class, interface or trait", where are classes should be declared ? |
Can be ignored 👍 |
components/runtime.rst
Outdated
| require_once dirname(__DIR__) . '/vendor/autoload_runtime.php'; | ||
|
|
||
| return static function (): RequestHandlerInterface { | ||
| return new class implements RequestHandlerInterface { |
There was a problem hiding this comment.
I don't think the common use case for a react-php application would be to define your request handler as an anonymous class in the front controller, as this does really allow testing your logic (or at least it makes it harder). The previous code suggesting to instantiate a class makes more sense to me (however, changing the return type of the closure to RequestHandlerInterface might make sense).
There was a problem hiding this comment.
Hello @stof , sure, in fact this PR is to avoid frustration about testing this example with a minimal source code. Why not showing what "SomeCustomPsr15Application" could looks like ? (on another piece of code) It is for having a full functional example, for you is it too much ? In my mind, when I read it, I came to the fact it misses "things", maybe it is enough to stop at the "SomeCustomPsr15Application", but it requires more research if we want to enjoy the moment we end the reading to enjoy.
There was a problem hiding this comment.
I keep it simple, the full example could be too much as it requires attention to maintain details about it in the future (it depends too much of an external lib)
components/runtime.rst
Outdated
|
|
||
| return function (array $context): SomeCustomPsr15Application { | ||
| return new SomeCustomPsr15Application(); | ||
| $_SERVER['APP_RUNTIME'] = ReactPhpRuntime::class; |
There was a problem hiding this comment.
Why does this need to be set here?
There was a problem hiding this comment.
It is for the application : by default it uses the SymfonyRuntime on the autoload_runtime, this is the way to choose our Runtime
$runtime = $_SERVER['APP_RUNTIME'] ?? $_ENV['APP_RUNTIME'] ?? 'Symfony\\Component\\Runtime\\SymfonyRuntime';There was a problem hiding this comment.
I am not sure if that is a good way to demo it in the example though. This would override whatever you would specify in the ENV of the webserver for example. Users might get the wrong impression.
There was a problem hiding this comment.
I will push a shorter version with all feedbacks, thanks @alcohol
There was a problem hiding this comment.
I push a new version without all this detail as explain just above to stof
Hello,
Based on update : https://github.com/reactphp/reactphp/blob/1.x/README.md
I make a more explicit example for reader to be able to test without being frustrated at the end of the doc.
GIT example :
Thanks :)