Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[String] add named arguments #19879

Merged
merged 1 commit into from
May 15, 2024
Merged

[String] add named arguments #19879

merged 1 commit into from
May 15, 2024

Conversation

OskarStark
Copy link
Contributor

@carsonbot carsonbot added this to the 7.1 milestone May 13, 2024
javiereguiluz
javiereguiluz approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is much better. Thanks Oskar!

@javiereguiluz javiereguiluz modified the milestones: 7.1, 6.4 May 15, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 May 15, 2024 14:40
@javiereguiluz
Copy link
Member

Merged! I merged it in 6.4 and up. Thanks.

@javiereguiluz javiereguiluz merged commit 819e7f2 into symfony:6.4 May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review String
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OskarStark @javiereguiluz @carsonbot