Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] Add missing XML serializer's CDATA options #19883

Merged
merged 1 commit into from
May 16, 2024
Merged

[Serializer] Add missing XML serializer's CDATA options #19883

merged 1 commit into from
May 16, 2024

Conversation

alexpozzi
Copy link
Contributor

Fixes #19851

@carsonbot carsonbot added this to the 7.1 milestone May 13, 2024
@alexpozzi alexpozzi mentioned this pull request May 13, 2024
Closed
@alexpozzi alexpozzi changed the title Add missing XML serializer's CDATA options [Serializer] Add missing XML serializer's CDATA options May 14, 2024
@OskarStark
Copy link
Contributor

#18155 should be merged first

@OskarStark
Copy link
Contributor

Please add a versionadded directive for your new option

@OskarStark
Copy link
Contributor

OskarStark commented May 16, 2024 •
edited

#18155 should be merged first

Done, please rebase

@alexpozzi alexpozzi force-pushed the add_missing_xml_serializer_options branch from cc4bcd4 to 53aeff4 Compare May 16, 2024 07:03
OskarStark
OskarStark reviewed May 16, 2024
View reviewed changes
components/serializer.rst Outdated
containing one of the following characters (
``<``, ``>``, ``&``) in `a CDATA section`_ like
following: ``<![CDATA[...]]>``
matching the `cdata_wrapping_pattern`_ regex in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the defined link for data_wrapping_pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake, sorry, I didn't want to make a link

@OskarStark
Copy link
Contributor

btw I fixed the DOCtor-RST build. I should be green after another rebase

@alexpozzi alexpozzi force-pushed the add_missing_xml_serializer_options branch from 53aeff4 to f178e95 Compare May 16, 2024 11:33
@alexpozzi alexpozzi force-pushed the add_missing_xml_serializer_options branch from f178e95 to c6d3512 Compare May 16, 2024 11:34
@OskarStark
Copy link
Contributor

Thank you Alessandro.

@alexpozzi alexpozzi requested a review from OskarStark May 16, 2024 11:35
@OskarStark OskarStark merged commit 4a052d5 into symfony:7.1 May 16, 2024
3 checks passed
@alexpozzi alexpozzi deleted the add_missing_xml_serializer_options branch May 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Serializer Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Serializer] Add XmlEncoder::CDATA_WRAPPING_PATTERN context option
3 participants
@alexpozzi @OskarStark @carsonbot