Skip to content

Commit

Permalink
minor #42906 Make test.session.listener compatible with SF 6.0 Sessio…
Browse files Browse the repository at this point in the history
…nListener (jderusse)

This PR was merged into the 5.4 branch.

Discussion
----------

Make test.session.listener compatible with SF 6.0 SessionListener

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Fix flipped tests for #41321

In Symfony 6.0, the session_listener does not use `session` service anymore, it needs a `session_factory` instead.

note: the `session_listener` service is properly configured:
https://github.com/symfony/symfony/blob/0d61de7576d0d6807924fada3df508c5d05d8f2f/src/Symfony/Bundle/FrameworkBundle/Resources/config/session.php#L146-L150

Commits
-------

0943685 Make test.session.listener compatible with SF 6.0 SessionListener
  • Loading branch information
nicolas-grekas committed Sep 6, 2021
2 parents 0d61de7 + 0943685 commit 03d673c
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -39,6 +39,7 @@
->args([
service_locator([
'session' => service('.session.do-not-use')->ignoreOnInvalid(),
'session_factory' => service('session.factory')->ignoreOnInvalid(),
]),
param('kernel.debug'),
param('session.storage.options'),
Expand Down

0 comments on commit 03d673c

Please sign in to comment.