Skip to content

Commit

Permalink
bug #35616 [Workflow] Make method signature compatible with 4.4 (pbow…
Browse files Browse the repository at this point in the history
…yer)

This PR was squashed before being merged into the 5.0 branch (closes #35616).

Discussion
----------

[Workflow] Make method signature compatible with 4.4

| Q             | A
| ------------- | ---
| Branch?       | 5.0 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35615  <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->
A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested.

For full details see ticket #35615.

Commits
-------

474be96 [Workflow] Make method signature compatible with 4.4
  • Loading branch information
lyrixx committed Feb 6, 2020
2 parents 29e5222 + 474be96 commit 0febb62
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Symfony/Component/Workflow/Event/Event.php
Expand Up @@ -60,7 +60,7 @@ public function getWorkflowName()
return $this->workflow->getName();
}

public function getMetadata(string $key, object $subject)
public function getMetadata(string $key, $subject)
{
return $this->workflow->getMetadataStore()->getMetadata($key, $subject);
}
Expand Down

0 comments on commit 0febb62

Please sign in to comment.