Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #35645 [ErrorHandler] Never throw on warnings triggered by assert…
…() and set assert.exception=1 in Debug::enable() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Never throw on warnings triggered by assert() and set assert.exception=1 in Debug::enable() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Because we don't use `assert()`, this is something we completely overlooked, but warnings triggered should not throw as there is already a dedicated exception mode when using `assert()`. This turns this exception mode to 1 in debug mode and logs the assert() warnings in prod. Commits ------- f18ef6c [ErrorHandler] Never throw on warnings triggered by assert() and set assert.exception=1 in Debug::enable()
- Loading branch information
Showing
3 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters