Skip to content

Commit

Permalink
minor #35999 [Mime] remove phpdoc mentioning Utf8AddressEncoder (dmai…
Browse files Browse the repository at this point in the history
…cher)

This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead.

Discussion
----------

[Mime] remove phpdoc mentioning Utf8AddressEncoder

This class does not exist

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I'm currently migrating from Swiftmailer fo Symfony mailer and stumbled upon this exception:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Mime/Encoder/IdnAddressEncoder.php#L44

The phpdoc of the class is a bit confusing/wrong. Seems to be a copy&paste leftover from Swiftmailer:

https://github.com/swiftmailer/swiftmailer/blob/master/lib/classes/Swift/AddressEncoder/IdnAddressEncoder.php#L19

Commits
-------

a85fb6c [Mime] remove phpdoc mentioning Utf8AddressEncoder
  • Loading branch information
fabpot committed Mar 9, 2020
2 parents c1ed100 + a85fb6c commit 14b825b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/Symfony/Component/Mime/Encoder/IdnAddressEncoder.php
Expand Up @@ -20,9 +20,7 @@
* SMTP servers.
*
* This encoder does not support email addresses with non-ASCII characters in
* local-part (the substring before @). To send to such addresses, use
* Utf8AddressEncoder together with SmtpUtf8Handler. Your outbound SMTP server must support
* the SMTPUTF8 extension.
* local-part (the substring before @).
*
* @author Christian Schmidt
*/
Expand Down

0 comments on commit 14b825b

Please sign in to comment.