Skip to content

Commit

Permalink
[HttpClient] fix HttpClientDataCollector when handling canceled respo…
Browse files Browse the repository at this point in the history
…nses
  • Loading branch information
nicolas-grekas committed Feb 2, 2020
1 parent 6f29d8d commit 303f9e5
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -116,7 +116,7 @@ private function collectOnClient(TraceableHttpClient $client): array

unset($info['filetime'], $info['http_code'], $info['ssl_verify_result'], $info['content_type']);

if ($trace['method'] === $info['http_method']) {
if (($info['http_method'] ?? null) === $trace['method']) {
unset($info['http_method']);
}

Expand Down

1 comment on commit 303f9e5

@maxim-dovydenok
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this commit, I was using 4.4.2 and found this bug when created a decorator that didn't send a request in some cases. But then I was not able to reproduce it on a newer branch, because you already fixed it here. Thanks a lot for your work!

Please sign in to comment.