Skip to content

Commit

Permalink
minor #36892 [Debug] Skip test that would trigger a fatal error on ph…
Browse files Browse the repository at this point in the history
…p 8 (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Skip test that would trigger a fatal error on php 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR skips a test of `DebugClassLoader`. The test uses incompatible method signatures in class inheritance to provoke a php warning that should be handled by the debug class loader. On php 8 however, this error is not recoverable anymore, so the tested logic will be obsolete there.

Commits
-------

573d0dd [Debug] Skip test that would trigger a fatal error on php 8.
  • Loading branch information
nicolas-grekas committed May 22, 2020
2 parents dd902d9 + 573d0dd commit 52abcbe
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Symfony/Component/Debug/Tests/DebugClassLoaderTest.php
Expand Up @@ -97,6 +97,9 @@ public function testUnsilencing()
$this->assertStringMatchesFormat('%aParse error%a', $output);
}

/**
* @requires PHP < 8.0
*/
public function testStacking()
{
// the ContextErrorException must not be loaded to test the workaround
Expand Down

0 comments on commit 52abcbe

Please sign in to comment.