Skip to content

Commit

Permalink
bug #36506 [FrameworkBundle] Fix session.attribute_bag service defini…
Browse files Browse the repository at this point in the history
…tion (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Fix session.attribute_bag service definition

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36465
| License       | MIT
| Doc PR        | -

It looks like in #36063, the fact the the `getAttributeBag` method is private was forgotten. It cannot be used as the factory method. I guess we can make it public. Should it maybe marked `@internal`?

Commits
-------

76072c6 [FrameworkBundle] Fix session.attribute_bag service definition
  • Loading branch information
nicolas-grekas committed Apr 21, 2020
2 parents 62565a1 + 76072c6 commit 6642f09
Showing 1 changed file with 2 additions and 1 deletion.
Expand Up @@ -41,7 +41,8 @@
<service id="Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface" alias="session.flash_bag" />

<service id="session.attribute_bag" class="Symfony\Component\HttpFoundation\Session\Attribute\AttributeBag">
<factory service="session" method="getAttributeBag"/>
<factory service="session" method="getBag"/>
<argument>attributes</argument>
</service>

<service id="session.storage.mock_file" class="Symfony\Component\HttpFoundation\Session\Storage\MockFileSessionStorage">
Expand Down

0 comments on commit 6642f09

Please sign in to comment.