Skip to content

Commit

Permalink
[Phpunit] Fix running skipped tests expecting only deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
chalasr authored and nicolas-grekas committed Feb 3, 2020
1 parent b90664b commit 6b02362
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
Expand Up @@ -222,6 +222,10 @@ public function startTest($test)
}
}

if (!$test->getTestResultObject()) {
return;
}

$annotations = $Test::parseTestMethodAnnotations(\get_class($test), $test->getName(false));

if (isset($annotations['class']['expectedDeprecation'])) {
Expand Down
@@ -0,0 +1,34 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\PhpUnit\Tests;

use PHPUnit\Framework\TestCase;

/**
* This test is meant to be skipped.
*
* @requires extension ext-dummy
*/
final class OnlyExpectingDeprecationSkippedTest extends TestCase
{
/**
* Do not remove this test in the next major versions.
*
* @group legacy
*
* @expectedDeprecation unreachable
*/
public function testExpectingOnlyDeprecations()
{
$this->fail('should never be ran.');
}
}

0 comments on commit 6b02362

Please sign in to comment.