Skip to content

Commit

Permalink
bug #37117 [Messenger/DoctrineBridge] set column length for mysql 5.6…
Browse files Browse the repository at this point in the history
… compatibility (Nemo64)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger/DoctrineBridge] set column length for mysql 5.6 compatibility

MySQL 5.6 does not support more than 191 characters when an index is used and when using utf8mb4 as charset.
As a workaround, I define the length of the queue_name field.

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37116
| License       | MIT

Commits
-------

d121906 set column length for mysql 5.6 compatibility
  • Loading branch information
nicolas-grekas committed Jun 7, 2020
2 parents a31d761 + d121906 commit 717de3e
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -390,6 +390,7 @@ private function addTableToSchema(Schema $schema): void
$table->addColumn('headers', self::$useDeprecatedConstants ? Type::TEXT : Types::TEXT)
->setNotnull(true);
$table->addColumn('queue_name', self::$useDeprecatedConstants ? Type::STRING : Types::STRING)
->setLength(190) // mysql 5.6 only supports 191 characters on an indexed column in utf8mb4 mode
->setNotnull(true);
$table->addColumn('created_at', self::$useDeprecatedConstants ? Type::DATETIME : Types::DATETIME_MUTABLE)
->setNotnull(true);
Expand Down

0 comments on commit 717de3e

Please sign in to comment.