Skip to content

Commit

Permalink
minor #54046 [HttpKernel] Increase log level to "error" at least for …
Browse files Browse the repository at this point in the history 
…all PHP errors (lyrixx)

This PR was merged into the 7.1 branch.

Discussion
----------

[HttpKernel] Increase log level to "error" at least for all PHP errors

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix #54036
| License       | MIT

reproducer: with a simple `$a = $b` in a controller.

Before
```
[PHP        ] [Fri Feb 23 17:14:26 2024] 127.0.0.1:42604 Accepted
[PHP        ] [Fri Feb 23 17:14:26 2024] 127.0.0.1:42604 [200]: GET /
[Web Server ] Feb 23 17:14:26 |INFO   | SERVER GET  (200) / ip="127.0.0.1"
[PHP        ] [Fri Feb 23 17:14:26 2024] 127.0.0.1:42604 Closing
```

After
```
[Web Server ] Feb 23 17:15:11 |INFO   | SERVER GET  (200) / ip="127.0.0.1"
[PHP        ] [Fri Feb 23 17:15:11 2024] 127.0.0.1:57906 Accepted
[PHP        ] {"message":"Matched route \"app_homepage_index\".","context":{"route":"app_homepage_index","route_parameters":{"_route":"app_homepage_index","_controller":"App\\Controller\\HomepageController::index"},"request_uri":"https://127.0.0.1:8000/","method":"GET"},"level":200,"level_name":"INFO","channel":"request","datetime":"2024-02-23T17:15:11.090004+01:00","extra":{}}
[PHP        ] {"message":"Checking for authenticator support.","context":{"firewall_name":"main","authenticators":0},"level":100,"level_name":"DEBUG","channel":"security","datetime":"2024-02-23T17:15:11.090469+01:00","extra":{}}
[PHP        ] {"message":"Warning: Undefined variable $b","context":{"exception":{"class":"ErrorException","message":"Warning: Undefined variable $b","code":0,"file":"/home/gregoire/dev/labs/symfony/symfony-7.1/src/Controller/HomepageController.php:20"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-02-23T17:15:11.090872+01:00","extra":{}}
[PHP        ] [Fri Feb 23 17:15:11 2024] 127.0.0.1:57906 [200]: GET /
[PHP        ] [Fri Feb 23 17:15:11 2024] 127.0.0.1:57906 Closing
```

Commits
-------

796950b [HttpKernel] Increase log level to "error" at least for all PHP errors
  • Loading branch information
@stof
stof committed Mar 14, 2024
2 parents e49f84b + 796950b commit 7e4f02e
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 23 deletions.
5 changes: 5 additions & 0 deletions src/Symfony/Component/ErrorHandler/CHANGELOG.md
View file
@@ -1,6 +1,11 @@
CHANGELOG
=========

7.1
---

* Increase log level to "error" at least for all PHP errors

6.4
---

Expand Down
18 changes: 9 additions & 9 deletions src/Symfony/Component/ErrorHandler/ErrorHandler.php
View file
Expand Up @@ -71,13 +71,13 @@ class ErrorHandler
private array $loggers = [
\E_DEPRECATED => [null, LogLevel::INFO],
\E_USER_DEPRECATED => [null, LogLevel::INFO],
\E_NOTICE => [null, LogLevel::WARNING],
\E_USER_NOTICE => [null, LogLevel::WARNING],
\E_STRICT => [null, LogLevel::WARNING],
\E_WARNING => [null, LogLevel::WARNING],
\E_USER_WARNING => [null, LogLevel::WARNING],
\E_COMPILE_WARNING => [null, LogLevel::WARNING],
\E_CORE_WARNING => [null, LogLevel::WARNING],
\E_NOTICE => [null, LogLevel::ERROR],
\E_USER_NOTICE => [null, LogLevel::ERROR],
\E_STRICT => [null, LogLevel::ERROR],
\E_WARNING => [null, LogLevel::ERROR],
\E_USER_WARNING => [null, LogLevel::ERROR],
\E_COMPILE_WARNING => [null, LogLevel::ERROR],
\E_CORE_WARNING => [null, LogLevel::ERROR],
\E_USER_ERROR => [null, LogLevel::CRITICAL],
\E_RECOVERABLE_ERROR => [null, LogLevel::CRITICAL],
\E_COMPILE_ERROR => [null, LogLevel::CRITICAL],
Expand Down Expand Up @@ -432,7 +432,7 @@ public function handleError(int $type, string $message, string $file, int $line)
return true;
}
} else {
if (PHP_VERSION_ID < 80303 && str_contains($message, '@anonymous')) {
if (\PHP_VERSION_ID < 80303 && str_contains($message, '@anonymous')) {
$backtrace = debug_backtrace(false, 5);

for ($i = 1; isset($backtrace[$i]); ++$i) {
Expand All @@ -448,7 +448,7 @@ public function handleError(int $type, string $message, string $file, int $line)
}
}

if (false !== strpos($message, "@anonymous\0")) {
if (str_contains($message, "@anonymous\0")) {
$message = $this->parseAnonymousClass($message);
$logMessage = $this->levels[$type].': '.$message;
}
Expand Down
28 changes: 14 additions & 14 deletions src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php
View file
Expand Up @@ -201,13 +201,13 @@ public function testDefaultLogger()
$loggers = [
\E_DEPRECATED => [null, LogLevel::INFO],
\E_USER_DEPRECATED => [null, LogLevel::INFO],
\E_NOTICE => [$logger, LogLevel::WARNING],
\E_NOTICE => [$logger, LogLevel::ERROR],
\E_USER_NOTICE => [$logger, LogLevel::CRITICAL],
\E_STRICT => [null, LogLevel::WARNING],
\E_WARNING => [null, LogLevel::WARNING],
\E_USER_WARNING => [null, LogLevel::WARNING],
\E_COMPILE_WARNING => [null, LogLevel::WARNING],
\E_CORE_WARNING => [null, LogLevel::WARNING],
\E_STRICT => [null, LogLevel::ERROR],
\E_WARNING => [null, LogLevel::ERROR],
\E_USER_WARNING => [null, LogLevel::ERROR],
\E_COMPILE_WARNING => [null, LogLevel::ERROR],
\E_CORE_WARNING => [null, LogLevel::ERROR],
\E_USER_ERROR => [null, LogLevel::CRITICAL],
\E_RECOVERABLE_ERROR => [null, LogLevel::CRITICAL],
\E_COMPILE_ERROR => [null, LogLevel::CRITICAL],
Expand Down Expand Up @@ -438,13 +438,13 @@ public function testBootstrappingLogger()
$loggers = [
\E_DEPRECATED => [$bootLogger, LogLevel::INFO],
\E_USER_DEPRECATED => [$bootLogger, LogLevel::INFO],
\E_NOTICE => [$bootLogger, LogLevel::WARNING],
\E_USER_NOTICE => [$bootLogger, LogLevel::WARNING],
\E_STRICT => [$bootLogger, LogLevel::WARNING],
\E_WARNING => [$bootLogger, LogLevel::WARNING],
\E_USER_WARNING => [$bootLogger, LogLevel::WARNING],
\E_COMPILE_WARNING => [$bootLogger, LogLevel::WARNING],
\E_CORE_WARNING => [$bootLogger, LogLevel::WARNING],
\E_NOTICE => [$bootLogger, LogLevel::ERROR],
\E_USER_NOTICE => [$bootLogger, LogLevel::ERROR],
\E_STRICT => [$bootLogger, LogLevel::ERROR],
\E_WARNING => [$bootLogger, LogLevel::ERROR],
\E_USER_WARNING => [$bootLogger, LogLevel::ERROR],
\E_COMPILE_WARNING => [$bootLogger, LogLevel::ERROR],
\E_CORE_WARNING => [$bootLogger, LogLevel::ERROR],
\E_USER_ERROR => [$bootLogger, LogLevel::CRITICAL],
\E_RECOVERABLE_ERROR => [$bootLogger, LogLevel::CRITICAL],
\E_COMPILE_ERROR => [$bootLogger, LogLevel::CRITICAL],
Expand Down Expand Up @@ -665,7 +665,7 @@ public function testAssertQuietEval()

$logs = $logger->cleanLogs();

$this->assertSame('warning', $logs[0][0]);
$this->assertSame('error', $logs[0][0]);
$this->assertSame('Warning: assert(): assert(false) failed', $logs[0][1]);
}

Expand Down

0 comments on commit 7e4f02e

Please sign in to comment.