[HttpClient] Throw JsonException instead of TransportException on emp…

…ty response in Response::toArray()
symfony · Jun 2, 2020 · 81c74a3 · 81c74a3
1 parent a2f4342
commit 81c74a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Symfony/Component/HttpClient/Response/ResponseTrait.php b/src/Symfony/Component/HttpClient/Response/ResponseTrait.php
@@ -137,7 +137,7 @@ public function getContent(bool $throw = true): string
     public function toArray(bool $throw = true): array
     {
         if ('' === $content = $this->getContent($throw)) {
-            throw new TransportException('Response body is empty.');
+            throw new JsonException('Response body is empty.');
         }
 
         if (null !== $this->jsonData) {

diff --git a/src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php b/src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php
@@ -35,6 +35,12 @@ public function testToArrayError($content, $responseHeaders, $message)
 
     public function toArrayErrors()
     {
+        yield [
+            'content' => '',
+            'responseHeaders' => [],
+            'message' => 'Response body is empty.',
+        ];
+
         yield [
             'content' => '{}',
             'responseHeaders' => ['content-type' => 'plain/text'],