Skip to content

Commit

Permalink
bug #39331 [PhpUnitBridge] Fixed PHPunit 9.5 compatibility (wouterj)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Fixed PHPunit 9.5 compatibility

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39329
| License       | MIT
| Doc PR        | -

Let's see if this works 🍀

#SymfonyHackday

Commits
-------

5134de5 Added compatibility with PHPunit 9.5
  • Loading branch information
fabpot committed Dec 5, 2020
2 parents d0d0ee3 + 5134de5 commit 9354958
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion phpunit
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if (!getenv('SYMFONY_PHPUNIT_VERSION')) {
} elseif (\PHP_VERSION_ID < 70300) {
putenv('SYMFONY_PHPUNIT_VERSION=8.5');
} else {
putenv('SYMFONY_PHPUNIT_VERSION=9.4');
putenv('SYMFONY_PHPUNIT_VERSION=9.5');
}
}
if (!getenv('SYMFONY_PATCH_TYPE_DECLARATIONS')) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function startTest($test)
return;
}

$annotations = $test->getAnnotations();
$annotations = Test::parseTestMethodAnnotations(\get_class($test), $test->getName(false));

$ignoredAnnotations = ['covers', 'coversDefaultClass', 'coversNothing'];

Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Security/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

<testsuites>
<testsuite name="Symfony Security Component Test Suite">
<directory>./Tests/</directory>
<directory>./*/Tests/</directory>
</testsuite>
</testsuites>
Expand All @@ -23,8 +22,6 @@
<whitelist>
<directory>./</directory>
<exclude>
<directory>./Resources</directory>
<directory>./Tests</directory>
<directory>./vendor</directory>
<directory>./*/Resources</directory>
<directory>./*/Tests</directory>
Expand Down

0 comments on commit 9354958

Please sign in to comment.