Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #36141 Prevent warning in proc_open() (BenMorel)
This PR was squashed before being merged into the 3.4 branch. Discussion ---------- Prevent warning in proc_open() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none In addition to returning `false`, `proc_open()` triggers a warning when it fails. For example: > Warning: proc_open(): fork failed - Cannot allocate memory When using the `ErrorHandler`, the warning gets promoted to an exception, and the next line, `if (! is_resource(...`, is not executed. This mutes the warning and ensures that the next line is always executed and the proper exception is thrown. Commits ------- d43833a Prevent warning in proc_open()
- Loading branch information