Skip to content

Commit

Permalink
minor #36402 [Twig][Mime] Removed extra quotes in missing package exc…
Browse files Browse the repository at this point in the history
…eption message (mikemilano)

This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead.

Discussion
----------

[Twig][Mime] Removed extra quotes in missing package exception message

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The missing package exception copy had a double quote in the composer command disrupting the ability to copy/paste the command.

> try running "composer require "twig/cssinliner-extra twig/inky-extra"

This PR removes the quote before the package name so it reads:

> try running "composer require twig/cssinliner-extra twig/inky-extra"

Commits
-------

b2c9a6e [Twig][Mime] Removed extra quotes in missing package exception message
  • Loading branch information
nicolas-grekas committed Apr 10, 2020
2 parents 0506f8c + b2c9a6e commit ac5f45b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Mime/NotificationEmail.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function __construct(Headers $headers = null, AbstractPart $body = null)
}

if ($missingPackages) {
throw new \LogicException(sprintf('You cannot use "%s" if the "%s" Twig extension%s not available; try running "composer require "%s"".', static::class, implode('" and "', $missingPackages), \count($missingPackages) > 1 ? 's are' : ' is', implode(' ', array_keys($missingPackages))));
throw new \LogicException(sprintf('You cannot use "%s" if the "%s" Twig extension%s not available; try running "%s".', static::class, implode('" and "', $missingPackages), \count($missingPackages) > 1 ? 's are' : ' is', 'composer require '.implode(' ', array_keys($missingPackages))));
}

parent::__construct($headers, $body);
Expand Down

0 comments on commit ac5f45b

Please sign in to comment.