Allowing empty secrets to be set

symfony · Apr 9, 2020 · c9bf0c8 · c9bf0c8
1 parent 0506f8c
commit c9bf0c8
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.php
@@ -96,6 +96,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $value = strtr(substr(base64_encode(random_bytes($random)), 0, $random), '+/', '-_');
         } elseif (!$file = $input->getArgument('file')) {
             $value = $io->askHidden('Please type the secret value');
+
+            if (null === $value) {
+                $io->warning('No value provided: using empty string');
+                $value = '';
+            }
         } elseif ('-' === $file) {
             $value = file_get_contents('php://stdin');
         } elseif (is_file($file) && is_readable($file)) {
@@ -106,12 +111,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             throw new \InvalidArgumentException(sprintf('File is not readable: "%s".', $file));
         }
 
-        if (null === $value) {
-            $io->warning('No value provided, aborting.');
-
-            return 1;
-        }
-
         if ($vault->generateKeys()) {
             $io->success($vault->getLastMessage());