Skip to content

Commit

Permalink
bug #36789 Change priority of KernelEvents::RESPONSE subscriber (marcw)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Change priority of KernelEvents::RESPONSE subscriber

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

This PR changes the priority of the `KernelEvents::RESPONSE` subscriber of the `ProfilerListener` so that it is the penultimate to be executed (just before `StreamedResponseListener`).

The reason is that other listeners that were executed after this one CAN change the response (such as `SessionListener` for example). This creates a headache when debugging, with a discrepancy between what is shown in a curl command, and by the Symfony profiler.

Commits
-------

6ed624a Change priority of KernelEvents::RESPONSE subscriber
  • Loading branch information
fabpot committed May 14, 2020
2 parents 3150104 + 6ed624a commit e5c82c5
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -119,7 +119,7 @@ public function onKernelTerminate(PostResponseEvent $event)
public static function getSubscribedEvents()
{
return [
KernelEvents::RESPONSE => ['onKernelResponse', -100],
KernelEvents::RESPONSE => ['onKernelResponse', -1012],
KernelEvents::EXCEPTION => ['onKernelException', 0],
KernelEvents::TERMINATE => ['onKernelTerminate', -1024],
];
Expand Down

0 comments on commit e5c82c5

Please sign in to comment.