bug #35987 [DoctrineBridge][DoctrineExtractor] Fix wrong guessed type…

… for "json" type (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[DoctrineBridge][DoctrineExtractor] Fix wrong guessed type for "json" type

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35968
| License       | MIT
| Doc PR        | -

After checking the code, it appears that `json` have a different behavior than `json_array`.

> In json_array doctrine was converting null or empty value to array, but json type doesn't do that

@norkunas is right about this. Consequently, we cannot safely guess a built in type for the `json` Doctrine type.

Commits
-------

f9f5f8d [DoctrineBridge][DoctrineExtractor] Fix wrong guessed type for "json" type

src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php

@@ -178,7 +178,6 @@ public function getTypes($class, $property, array $context = [])
                     switch ($typeOfField) {
                         case self::$useDeprecatedConstants ? DBALType::TARRAY : 'array':
                         case 'json_array':
-                        case self::$useDeprecatedConstants ? false : Types::JSON:
                             return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true)];
 
                         case self::$useDeprecatedConstants ? DBALType::SIMPLE_ARRAY : Types::SIMPLE_ARRAY:
@@ -266,7 +265,6 @@ private function getPhpType($doctrineType)
             case self::$useDeprecatedConstants ? DBALType::TARRAY : 'array':
             case self::$useDeprecatedConstants ? DBALType::SIMPLE_ARRAY : Types::SIMPLE_ARRAY:
             case 'json_array':
-            case self::$useDeprecatedConstants ? false : Types::JSON:
                 return Type::BUILTIN_TYPE_ARRAY;
         }
 

src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php

@@ -182,7 +182,7 @@ public function typesProvider()
         ];
 
         if (class_exists(Types::class)) {
-            $provider[] = ['json', [new Type(Type::BUILTIN_TYPE_ARRAY, true, null, true)]];
+            $provider[] = ['json', null];
         }
 
         return $provider;