[Filesystem] Several issues with Filesystem::makePathRelative

[inso]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	master

Looking at the code of Filesystem::makePathRelative method I have found several issues:

• Stripping of drive letter for arguments is done regardless of host OS but directory separator normalization is done only for Windows hosts.
• There is no drive check for Windows paths, hence for the following case result will be invalid: (new Filesystem())->makePathRelative('C:/aa/bb/cc', 'D:/aa/dd/..') produces 'bb/cc/'
• (new Filesystem())->makePathRelative('/aa/bb/cc', '/aa') produces 'bb/cc/' which is wrong since '/aa/bb/cc' can be the file path, the presence of trailing slash in the result should be based on presence of trailing slash in the $endPath argument.

[nicolas-grekas]

@inso would you up to submit a PR to fix what you found?

[lainosantos]

Hello, there is any update for this issue?

Make relative path when the first argument is a file returns a wrong response, because it return a string with a slash at end.

[xabbuh]

@lainosantos Would you like to work on a fix?

[lainosantos]

@xabbuh , i'll do it. Thanks.

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3

[xabbuh]

The first issue has already been fixed in #36497.