[Filesystem] Updated Filesystem::makePathRelative #25022
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you maybe try to solve the issues you've mentioned in #25023 ? Failing tests are already a great contribution! |
|
@sroze yes, sure. I just wanted to receive some feedback. |
xabbuh
approved these changes
Nov 21, 2017
|
Issues mentioned in #25023 should be fixed in a different PR, against the lowest branches where they apply. |
|
Thank you @inso. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Filesystem] Updated Filesystem::makePathRelative | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Removed checks for absolute paths since Symfony >= 4.0 drops support for relative paths. Commits ------- 9da7c50 removed checks for absolute paths
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed checks for absolute paths since Symfony >= 4.0 drops support for relative paths.