Prevent warning in proc_open() #36141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 19, 2020
chalasr
approved these changes
Mar 19, 2020
|
@nicolas-grekas Done! |
fabpot
approved these changes
Mar 20, 2020
|
Thank you @BenMorel. |
|
Thank you. Will this be merged in 4.x and 5.x? |
This was referenced Mar 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to returning
false,proc_open()triggers a warning when it fails. For example:When using the
ErrorHandler, the warning gets promoted to an exception, and the next line,if (! is_resource(..., is not executed. This mutes the warning and ensures that the next line is always executed and the proper exception is thrown.