[Form] Support customized intl php.ini settings #36149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorrit
force-pushed
the
intlinisettings
branch
2 times, most recently
from
ddc608e
to
251aa20
Compare
...mfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
intlinisettings
branch
from
2c5685d
to
014259c
Compare
`IntlDateParser->parse()` behaves differently when `intl.error_level` and/or `intl.use_exceptions` are not 0. This change makes sure `\IntlException` is caught when `intl.use_exceptions` is 1 and warnings thrown when `intl.error_level` is not 0 are ignored.
nicolas-grekas
force-pushed
the
intlinisettings
branch
from
014259c
to
61025d1
Compare
|
Thank you @jorrit. |
|
No problem @nicolas-grekas, thanks for merging! |
This was referenced Mar 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntlDateParser->parse()behaves differently whenintl.error_leveland/orintl.use_exceptionsare not 0.This change makes sure
\IntlExceptionis caught whenintl.use_exceptionsis 1 and warnings thrown whenintl.error_levelis not 0 are ignored.