Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable intl.use_exceptions in debug mode #46871

Closed
wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Let's be stricter by default in debug mode.

@carsonbot carsonbot added this to the 6.2 milestone Jul 6, 2022
@nicolas-grekas
Copy link
Member Author

Hum, not sure about this on second thought: when enabled in dev, ppl will write try/catch. But in prod, intl will likely behave with no exceptions and the code should be written differently to handle that. The correct way to use intl in a portable way is to handle both situations, like we did in #36149
But there is no way to force ppl to handle both cases so most of the time they will stick to one mode, and then, prod&dev should be aligned.
PHP'd better deprecate this ini setting altogether and stick to one and only one mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants